FrankReh
FrankReh
@ollie-etl @rrichardson I've mentioned this to Noah too. I don't want the single threaded case to suffer much if the crate is trying to support multi threaded some day, but...
I think this a good discussion, worth keeping open, even if we don't know the next step yet.
I saw your PR before this issue. So my comments in that PR could be read first to avoid further confusion, but whatever. There is a PR just submitted to...
Wanted to get the reproducer committed to GitHub, one way or the other, so I didn't have to keep track of it locally. Will update the open Issue with this...
@Noah-Kennedy Sounds good. I'll work on that soon. That begs the question whether submit_with in https://github.com/tokio-rs/tokio-uring/blob/913aa14c567cfae026b7d4f88a5155921cfb9575/src/driver/op.rs#L61-L91 should continue to return an io::Result. An argument could be made that it future...
This is probably very reasonable but three things come to mind.
1. Why do we go through so much trouble to protect close in the first place? It's the file descriptor in the kernel that is the critical resource and it...
2. I think this PR should sit, or be gated, while the https://github.com/tokio-rs/tokio-uring/pull/222 is outstanding, because how to handle trying to take a raw fd when the File or SharedFd...
3. Was going to be "where's the comment explaining what this enables?". But I saw the top description again and I think the quoted example makes it clear enough.
Does the whole notion of going from File to raw and back to a new File, when the SharedFd can be cloned, and defining the close call to triggered when...