Frank Chen

Results 103 comments of Frank Chen

AFAIK, there's no such config to suppress audit log. I think currently you have to delete these logs by some code executing a delete sql periodically. I don't know the...

The new tests fails and the log shows as ``` 2022-09-20 13:56:15 02423_ddl_for_opentelemetry: [ FAIL ] 2.41 sec. - result differs with reference: 2022-09-20 13:56:15 Binary files /ClickHouse/tests/queries/0_stateless/02423_ddl_for_opentelemetry.reference and /ClickHouse/tests/queries/0_stateless/02423_ddl_for_opentelemetry.stdout...

The failed tests look like has nothing to do these the changes in the PR. Update the branch th see if it helps.

Hello @tavplubix do you know how can I exclude the new tests from `Stateless tests (release, DatabaseReplicated) `? Because there're ON CLUSTER DDLs in these cases, and these DDLs are...

> Add `no-replicated-database` tag > I've added such tag to test case, but it's still executed. > It's because `Replicated` database replicates DDL queries itself (almost the same way as...

> You have added it to another test, see diff You're right. Such a stupid mistake😄

@tavplubix Thank you. But the case for Replicated database fails because the ddl format entry version does not affect its flow which is a little bit different from non-replicated database....

> I suppose it's because Replicated database creates DDL entry through `DatabaseReplicated::tryEnqueueReplicatedDDL`/`DatabaseReplicatedDDLWorker::tryEnqueueAndExecuteEntry`, not through `executeDDLQueryOnCluster` as usual ON CLUSTER query does. Maybe adding `OpenTelemetry::SpanHolder span(__FUNCTION__);` and `entry.tracing_context = OpenTelemetry::CurrentContext();` to...

Interesting, the ON CLUSTER DDL output it's execution status to stdout while I explicitly supress it by given `distributed_ddl_output_mode=none`. And such execution status is not printed on my local.

The `Stateless tests (release, DatabaseReplicated)` still fails. The first DDL threw exception while the other DDLs were executed successfully. ``` 2022.09.24 03:19:16.208831 [ 664 ] {} DynamicQueryHandler: Request URI: /?max_insert_threads=6&group_by_two_level_threshold=100000&group_by_two_level_threshold_bytes=50000000&distributed_aggregation_memory_efficient=0&fsync_metadata=0&output_format_parallel_formatting=0&input_format_parallel_parsing=1&min_chunk_bytes_for_parallel_parsing=21409094&max_read_buffer_size=582693&prefer_localhost_replica=1&max_block_size=8857&max_threads=48&optimize_or_like_chain=1&optimize_read_in_order=0&read_in_order_two_level_merge_threshold=41&optimize_aggregation_in_order=0&aggregation_in_order_max_block_bytes=31524761&use_uncompressed_cache=0&min_bytes_to_use_direct_io=0&min_bytes_to_use_mmap_io=0&local_filesystem_read_method=pread_threadpool&remote_filesystem_read_method=threadpool&local_filesystem_read_prefetch=1&remote_filesystem_read_prefetch=0&compile_expressions=0&compile_aggregate_expressions=1&compile_sort_description=0&merge_tree_coarse_index_granularity=5&optimize_distinct_in_order=0&optimize_sorting_by_input_stream_properties=1&database=test_b6b84g3f&log_comment=02423_ddl_for_opentelemetry.sh&distributed_ddl_output_mode=none&distributed_ddl_entry_format_version=1...