Frank Chen comments

Results 103 comments of


                                            Frank Chen

Improve the opentelemetry tracing context propagation across threads

There might be conflicts once #38965 is merged

Improve the opentelemetry tracing context propagation across threads

How did that issue come out? Since original tracing context is initialized by `ThreadStatus::setupState` which might be called for one more time(for example, if a materialized view will be executed),...

Improve the opentelemetry tracing context propagation across threads

@qoega sure

Improve the opentelemetry tracing context propagation across threads

@qoega The Fast Test has passed. Could you review this PR at your convenience?

Improve the opentelemetry tracing context propagation across threads

@qoega Any updates?

Improve the opentelemetry tracing context propagation across threads

Hi @qoega , do you have a plan to review this PR?

Improve the opentelemetry tracing context propagation across threads

Thank you @rschu1ze

Improve the opentelemetry tracing context propagation across threads

@qoega What does this error mean? I thought it was because `std::to_string` which allocates memory from heap, but after I changed it to `DB::toString`, the CI still reports this error.

Improve the opentelemetry tracing context propagation across threads

@rschu1ze Thanks for your comments. I will address them in next commit.

Improve the opentelemetry tracing context propagation across threads

Hi @rschu1ze about the failed stateless tests, do you confirm that if opentelemetry tracing is enabled for these tests? Because I see there's exception thrown from destructor of `TracingContextHolder` to...