GAPointNet icon indicating copy to clipboard operation
GAPointNet copied to clipboard

Slight confusion with variable names

Open AI-Guru opened this issue 5 years ago • 0 comments

Hello!

First of all, I really like your approach. This is some very solid work! Congratulations.

I think I have found a slight discrepancy. Between lines https://github.com/FrankCAN/GAPointNet/blob/master/models/network.py#L32 and https://github.com/FrankCAN/GAPointNet/blob/master/models/gat_layers.py#L56

You see, attn_feature() returns "ret, coefs, edge_feature", while getmodel() unpacks the values as "edge_feature, coefs, locals". The order is slightly different. What do you think?

AI-Guru avatar Nov 06 '19 14:11 AI-Guru