libosmscout icon indicating copy to clipboard operation
libosmscout copied to clipboard

Lane suggestion rewrite

Open Karry opened this issue 1 year ago • 3 comments

Suggested route lanes are based on turn geometry now (DirectionDescription).

But based on my experience and extensive report https://github.com/Karry/osmscout-sailfish/issues/326 , it provides misleading results on many junctions. So, it should analyze lanes and angles of all ways connected to the analyzed junction node...

Karry avatar May 17 '24 20:05 Karry

it works on simple junction, will need to test it with more complex one...

Karry avatar Jul 07 '24 08:07 Karry

there is still some room for improvements (see TODOs in the tests), but it behaves better than current solution IMHO...

Karry avatar Sep 02 '24 22:09 Karry

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Sep 02 '24 22:09 sonarqubecloud[bot]

Hi @karry, the routing crash on the following assert:

osmin: /home/jlb/src/janbar/QML/osmin-qt6/backend/libosmscout/libosmscout/src/osmscout/routing/RoutePostprocessor.cpp :1978 :
virtual osmscout::NodeRef osmscout::RoutePostprocessor::GetNode(const osmscout::DBFileOffset&) const:  l'assertion « entry!=nodeMap.end() » a échoué.

Map: Europe/France/Ile-de-france version 26 build on 2024-08-05 from osm data Departure from: N 48°33.798' E 2°14.502' Arrived to: N 48°27.377' E 2°03.320'

Has I need to rebuild the map version 26, made before this PR ?

janbar avatar Sep 07 '24 23:09 janbar

Thank you for the notice. Here is the fix: https://github.com/Framstag/libosmscout/pull/1599

Karry avatar Sep 08 '24 12:09 Karry