EmbeddedController icon indicating copy to clipboard operation
EmbeddedController copied to clipboard

[Bug Report]: Power button suppression when fingerprint scanner is polling does not function on Framework 13 AMD

Open TheBlueKingLP opened this issue 11 months ago • 8 comments

The Problem

I sometimes presses the power button accidentally(putting a bit too much pressure on it and triggered the button under the sensor) when my intention was to use the fingerprint reader.

Proposed solution

An option for enabling a delay that requires the user to hold the power button for maybe 0.5 second to 1 second, would be appreciated. This is the behavior on some of my other laptops that has the fingerprint sensor on the power button.

TheBlueKingLP avatar Mar 23 '25 19:03 TheBlueKingLP

When the fingerprint reader is in use, i.e. when OS requests authentication, the power button functionality is already disabled. There is no need for the workaround you describe.

Could you describe the exact situation that you are having issues with?

JohnAZoidberg avatar Mar 27 '25 11:03 JohnAZoidberg

Which device are you using? Maybe there's a bug on the particular system that you are using? Here you can see the code that is responsible for this on the Intel Core Ultra Series 1 system: https://github.com/FrameworkComputer/EmbeddedController/blob/74a8e9ae2e2576e0e24e19cf49666708aedadea8/zephyr/program/framework/src/board_function.c#L116-L132

JohnAZoidberg avatar Mar 27 '25 11:03 JohnAZoidberg

Here you can see me trying it on the new AMD Ryzen AI 300 system. The power button does not react, while the system is requesting fingerprint authentication.

https://github.com/user-attachments/assets/dac8e20d-dc5a-4f2e-8201-10979525fc22

JohnAZoidberg avatar Mar 27 '25 11:03 JohnAZoidberg

Here you can see me trying it. The power button does not react, while the system is requesting fingerprint authentication. PXL_20250327_113219782.LS.mp4

Interesting, that is not the case for me. I just tried the fprintd-verify command as well, however unlike in your case, my Framework laptop went into sleep mode. My unit is a Framework 13 AMD.

TheBlueKingLP avatar Mar 27 '25 11:03 TheBlueKingLP

In this case, I assume this would be a bug instead of a feature request then?

TheBlueKingLP avatar Mar 27 '25 11:03 TheBlueKingLP

In this case, I assume this would be a bug instead of a feature request then?

That's right, will try to reproduce on AMD Ryzen 7040.

JohnAZoidberg avatar Mar 27 '25 12:03 JohnAZoidberg

Sorry, I forgot to answer, @TheBlueKingLP . I cannot reproduce your issue on the Ryzen 7040 systems either.

JohnAZoidberg avatar May 03 '25 12:05 JohnAZoidberg

Maybe you keep pressing the button after fingerprint verification has passed? Could you send a video of what's happening?

JohnAZoidberg avatar May 03 '25 12:05 JohnAZoidberg