ssh-tpm-agent icon indicating copy to clipboard operation
ssh-tpm-agent copied to clipboard

Fail to run keyring tests

Open adamcstephens opened this issue 8 months ago • 1 comments

As discussed in https://github.com/NixOS/nixpkgs/pull/394097. We've patched around this for now, but since you suggested this may be a bug I'm opening an issue here.

ok      github.com/foxboron/ssh-tpm-agent/contrib       0.002s
--- FAIL: TestNokey (0.00s)
    keyring_test.go:37: err: no such file or directory
--- FAIL: TestRemoveKey (0.00s)
    keyring_test.go:64: we can still read the key
--- FAIL: TestNokeyThreaded (0.00s)
    threadkeyring_test.go:45: err: no such file or directory
--- FAIL: TestRemoveKeyThreaded (0.00s)
    threadkeyring_test.go:75: we can still read the key
FAIL
FAIL    github.com/foxboron/ssh-tpm-agent/internal/keyring      0.004s

adamcstephens avatar Apr 15 '25 22:04 adamcstephens

It was originally brought up in this PR. But as everything is passing on my end I didn't quite grok if it was an actual issue or not.

https://github.com/Foxboron/ssh-tpm-agent/pull/91

Foxboron avatar Apr 15 '25 22:04 Foxboron

See: https://github.com/Foxboron/ssh-tpm-agent/pull/94#issuecomment-2932568075

You need to install the proper helpers for the test suite to run. Turns out this is not an upstream issue.

Foxboron avatar Jun 02 '25 21:06 Foxboron

Closing this as this is not an ssh-tpm-agent issue.

Foxboron avatar Jun 03 '25 20:06 Foxboron