sbctl icon indicating copy to clipboard operation
sbctl copied to clipboard

Check a few errors that are currently being ignored

Open WhyNotHugo opened this issue 2 years ago • 2 comments

WhyNotHugo avatar Jul 04 '22 10:07 WhyNotHugo

Okay, I didn't bother correcting all the if err...; err != nil { stuff in the review :p sorry!

Generally looks okay something we should have been doing for a while :)

Foxboron avatar Jul 05 '22 19:07 Foxboron

Generally looks okay something we should have been doing for a while :)

I've been using golangci-lint to sniff all these out quickly:

> cat =golint 
#!/bin/sh

podman run --rm -v "$(pwd):/src" -w /src \
  -v "${GOPATH:-$HOME/go}:/go" \
  docker.io/golangci/golangci-lint:v1.46 \
  golangci-lint run --color=always

gopls is also very helpful

WhyNotHugo avatar Jul 05 '22 19:07 WhyNotHugo