FabricZero icon indicating copy to clipboard operation
FabricZero copied to clipboard

Contribute upstream

Open Madis0 opened this issue 5 years ago • 3 comments

From readme:

Fix OptiFabric / Optifine compatibility with many mods Ex: (Lithium, Phosphor, REI, and more)

Perhaps you'd be interested in forking and maintaining OptiFabric?

Allow ModUpdater to update all mods without having to download them one by one

  • opt-in many mods to mod updater that haven't

Why make a new mod for that instead of contributing the changes to upstream? That way everyone could benefit.

Fix crash in many mods

Seems like something suited for Fabric API itself

Note: I haven't tested the mod yet but it seems promising, just wondering why you'd create a new mod instead of contributing patches.

Madis0 avatar Aug 07 '20 09:08 Madis0

The way FabricZero hook Fabric is by using reflection and the latest version of java block reflection

  • I almost destroyed my health by trying to fix the previous issue because I have an unstable health

I actually don't have the health to upstream anything but If the original mod author want to steal my code they explicitly can
For now, I don't have the strength to do anything you said here.

Fox2Code avatar Aug 07 '20 11:08 Fox2Code

@Fox2Code Thank you for the mod, Hope you get well soon, just an advice ,please take care of your health,don't ditch it in favour of modding,Your health is MUCH MUCH MUCH more important. Again,get well soon❤️

ghost avatar Aug 07 '20 13:08 ghost

If someone does pull request I will still review them but from now I will take a pause on FabricZero because it's not just a simple random mod and because I am not in my best condition I made a lot of coding mistakes.

And if a dev has the will to fix the stupid mistake I made I will accept it and add the person to the author inside fabric.mod.json if the person wants.

Fox2Code avatar Aug 07 '20 13:08 Fox2Code