Mailspring icon indicating copy to clipboard operation
Mailspring copied to clipboard

Making composer recipient name warnings optional

Open arhanjain opened this issue 2 years ago • 3 comments

Hey, this is my first stab at open source contributions. I'm working on this feature suggestion. So far I've split the DraftSession::validateDraftForSending by making a separate validateDraftRecipients as described by @bengotow. I will start working on the portion of adding a button to ignore warnings for that email, but wanted to check whether my approach for the first part is acceptable or requires tweaking.

arhanjain avatar Aug 18 '22 20:08 arhanjain

Hey @arhanjain

Thanks a lot for taking this up! As I am traveling right now, I could only take a short glance via mobile, but I could not spot and big issues with the code. So, I would say, feel free to go on with it! I will definitely have another look once I am back (unless Ben did this already in the meantime).

Cheers Phylu.

Phylu avatar Aug 18 '22 21:08 Phylu

I believe the changes specified in the feature suggestion have been implemented with these commits. Let me know if there's any issues or improvements I can make, but no rush. Enjoy your travels Phylu :)

arhanjain avatar Aug 19 '22 19:08 arhanjain

Just had another quick view. I think, there should also be an option (in the preferences) to reset the emails that don't get the warning anymore.

If I remember correctly there is a button with similar functionality for resetting the spellchecking that you might want to have a look at.

Phylu avatar Aug 19 '22 19:08 Phylu