Mailspring icon indicating copy to clipboard operation
Mailspring copied to clipboard

Use homeishome to improve experience for Snap users

Open kz6fittycent opened this issue 2 years ago • 4 comments

Should see increased snap loading performance using LZO.

kz6fittycent avatar Sep 17 '21 19:09 kz6fittycent

Added homeishome-launch to improve user experience. When saving documents to /home/user, the experience will be more seamless.

kz6fittycent avatar Oct 13 '21 13:10 kz6fittycent

This seems reasonable to me, but the binding is pretty loose and the homeishome-launch / homeishome projects don't seem to have much traction - I'm a little hesitant to re-route calls for password storage through homeishome.so because a maintainer could push a commit to that repo and siphon out user credentials. Maybe we let this one sit and see if the project picks up traction? Ideally this would actually be part of snapcraft itself 😬

I went ahead and pulled in the first commit with the LSO change! https://github.com/Foundry376/Mailspring/commit/f9d7fc0528270f4380a0b6e68933269f452d017e

bengotow avatar Nov 22 '21 03:11 bengotow

This seems reasonable to me, but the binding is pretty loose and the homeishome-launch / homeishome projects don't seem to have much traction - I'm a little hesitant to re-route calls for password storage through homeishome.so because a maintainer could push a commit to that repo and siphon out user credentials. Maybe we let this one sit and see if the project picks up traction? Ideally this would actually be part of snapcraft itself grimacing

I went ahead and pulled in the first commit with the LSO change! f9d7fc0

That's fine and I can understand your reluctance. That said, I've been using homeishome-launch is several of my snaps w/o issue. That said, security in email clients is something I can agree with.

I would highly recommend switching to lzo compression - load times will improve "dramatically".

kz6fittycent avatar Nov 23 '21 00:11 kz6fittycent

Wow I just ran the beta of the 1.9.3 as a snap and the LZO setting really does make a huge difference. Thanks! I'll rename this to just focus on the remaining homeishome bit and we can ship that in a future release once it's been adopted a bit 🙌

bengotow avatar Nov 25 '21 21:11 bengotow