open email: keep white content area

[avelino]

fixed: #2109

[CLAassistant]

All committers have signed the CLA.

[bengotow]

Hey folks! Thanks for filing this—I think that this might have a few inadvertent effects. I think there are a few dark mode themes that try to do a transparent background and make the text on top white. In that case hardcoding the background color to ignore the theme will make it white-on-white. I think we probably want to inject the white background into the email iframe CSS #inbox-html-wrapper here: https://github.com/Foundry376/Mailspring/blob/master/app/static/style/email-frame.less#L72:L72. I think that'd also let themes (like the built in dark theme) that automatically invert the email coloring to achieve black-on-white instead of white-on-black keep doing what they're doing!

[avelino]

@bengotow would that be your recommendation?

[foundry376-bot]

This pull request has been mentioned on Mailspring Community. There might be relevant details there:

https://community.getmailspring.com/t/poor-text-rendering-in-dark-theme/886/7

[CodeMouse92]

@avelino This topic has come up again here: https://community.getmailspring.com/t/poor-text-rendering-in-dark-theme/886

I think what @bengotow posted would indeed be the recommendation. Furthermore, we were discussing in the thread above making the dark/light-mode emails a separate option from UI theme. We'd appreciate if you weighed in there, and even more if you would be willing to update this PR to incorporate Ben's suggestion, and maybe even that toggle option.