fdb-record-layer icon indicating copy to clipboard operation
fdb-record-layer copied to clipboard

Remove OnlineIndexer functions that take Key.Evaluateds

Open alecgrieser opened this issue 6 years ago • 2 comments

The online indexing API defines a few places where it takes a Key.Evaluated (and also usually defines an overload where it takes a Tuple). Most of the API, however, uses Tuples as primary keys, so that seems like the more logical way to specify key ranges (and also will save some conversions to and from Tuples and Key.Evaluateds).

This is, of course, a breaking change for those who are using the API. I think we can remove all internal usage and then deprecate those methods...probably.

alecgrieser avatar Nov 30 '18 19:11 alecgrieser

@alecgrieser, is that (yet) an open issue?

jjezra avatar Sep 05 '21 23:09 jjezra

I'm not sure I understand the question. I think this is still an open issue, unless someone removed the Key.Evaluated methods or we decided that we do want to keep them, for some reason

alecgrieser avatar Sep 07 '21 16:09 alecgrieser