fdb-record-layer icon indicating copy to clipboard operation
fdb-record-layer copied to clipboard

Published 20 hours ago • verified publisher icon FoundationDB

improvements for joins

Open normen662 opened this issue 2 years ago • 15 comments

  • fixes a matching problem in ComputingMatcher where a join predicate could not be matched because the match was not considered.
  • change the data access rules in a way that joins can be planned utilizing join indexes (once we have them) as well utilize index matches using local and join indexes.
  • changes in the matching logic to properly treat join predicates.
  • lots of performance-oriented changes which either address over-enumeration or implementation snafus like excessive list-copying, etc.
  • I added several comments titled Comment for reviewer which are placed at the preamble of a class or if pertaining to a particular piece of logic near the place it's talking about. I tried to only address why the change is necessary, not necessarily how it works as that should go into comments if not already there.

normen662 avatar Aug 03 '22 20:08 normen662

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 4fd7beca4f9cce3f7d649c14d7bb6e06a86801f5
  • Duration 0:07:04
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 03 '22 20:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 4fd7beca4f9cce3f7d649c14d7bb6e06a86801f5
  • Duration 0:07:05
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 03 '22 20:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 0ec77f0226e1d4713f27ba00a620fe1da909f4cd
  • Duration 0:07:11
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 09 '22 14:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 0ec77f0226e1d4713f27ba00a620fe1da909f4cd
  • Duration 0:07:24
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 09 '22 14:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 2c240f9f54825c07c28691a3790ee550b647b53e
  • Duration 0:07:05
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 10 '22 04:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 2c240f9f54825c07c28691a3790ee550b647b53e
  • Duration 0:07:07
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 10 '22 04:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 663ca92043856e7965633733c9d9f986078cf826
  • Duration 0:15:34
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 10 '22 21:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 663ca92043856e7965633733c9d9f986078cf826
  • Duration 0:16:01
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 10 '22 21:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: eb4c74fbf68cc37407f42b93d3b2d76738e7b1ba
  • Duration 0:15:36
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 11 '22 00:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: eb4c74fbf68cc37407f42b93d3b2d76738e7b1ba
  • Duration 0:16:23
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 11 '22 00:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 1258142e01c259284d7187f9b299091fae5c8d05
  • Duration 0:12:28
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 16:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 1258142e01c259284d7187f9b299091fae5c8d05
  • Duration 0:13:30
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 16:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 3c1eb949330a20b2376babdf88981f0ab1a50003
  • Duration 0:15:14
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 19:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 3c1eb949330a20b2376babdf88981f0ab1a50003
  • Duration 0:16:05
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 19:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: cdb4e9733f2d463be88660cc06efdc0d5578fabc
  • Duration 0:15:25
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 16 '22 17:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: cdb4e9733f2d463be88660cc06efdc0d5578fabc
  • Duration 0:16:00
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 16 '22 17:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: bfbc1af880253597be6a436b0f5b4b5589f22cc8
  • Duration 0:15:35
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 02:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: bfbc1af880253597be6a436b0f5b4b5589f22cc8
  • Duration 0:16:00
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 02:08 foundationdb-ci

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 3c981cdd569fe4fcd7a22459894815fca36c818f
  • Duration 0:07:00
  • Result: :x: FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest sonarqube -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 22:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 3c981cdd569fe4fcd7a22459894815fca36c818f
  • Duration 0:15:41
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 22:08 foundationdb-ci

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 112 Code Smells

0.0% 0.0% Coverage
5.1% 5.1% Duplication

sonarqubecloud[bot] avatar Aug 18 '22 23:08 sonarqubecloud[bot]

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: b5e856e69ec0378b7f1baf7021a9e361f2a794ab
  • Duration 0:15:21
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 23:08 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: b5e856e69ec0378b7f1baf7021a9e361f2a794ab
  • Duration 0:16:18
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 23:08 foundationdb-ci