fdb-record-layer icon indicating copy to clipboard operation
fdb-record-layer copied to clipboard

Published 20 hours ago • verified publisher icon FoundationDB

Fixes #1601: Make EvaluationContextBuilder API backwards compatible

Open alecgrieser opened this issue 2 years ago • 7 comments

This makes the TypeRepository handling in the EvaluationContext API more-buildery, with a default value of TypeRepository.EMPTY_SCHEMA. This also simplifies some logic that was creating a child builder off of a parent context and then had to remember to pass in the parent's TypeRepository to the new child, as that's now handled by the Builder itself, though it is still possible for the child to override the TypeRepository if it wishes. This is a breaking API change of of 3.1.248.0, though it reverts it back to something that is backwards compatible with 3.1.247.0.

This fixes #1601.

alecgrieser avatar Apr 08 '22 17:04 alecgrieser

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto2
  • Commit ID: a446fcc3ca19a541c8ba0a1ae0b47d3f9cbe1e87
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Apr 08 '22 17:04 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto3
  • Commit ID: a446fcc3ca19a541c8ba0a1ae0b47d3f9cbe1e87
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Apr 08 '22 17:04 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto2
  • Commit ID: 089a60c0ad38b95591cff95bda27bd36e2e7aed8
  • Result: FAILED
  • Error: Error while executing command: . /etc/profile.d/gradle.sh. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Apr 08 '22 17:04 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto2
  • Commit ID: 089a60c0ad38b95591cff95bda27bd36e2e7aed8
  • Result: FAILED
  • Error: Error while executing command: . /etc/profile.d/gradle.sh. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Apr 08 '22 18:04 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto3
  • Commit ID: 089a60c0ad38b95591cff95bda27bd36e2e7aed8
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Apr 08 '22 18:04 foundationdb-ci

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 08 '22 18:04 sonarqubecloud[bot]

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto2
  • Commit ID: 089a60c0ad38b95591cff95bda27bd36e2e7aed8
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Apr 08 '22 18:04 foundationdb-ci

At this point, we've had the new API in a bit, and so regaining backwards compatibility is probably not as big a priority here. I'll go ahead and close this PR.

alecgrieser avatar Oct 26 '22 09:10 alecgrieser