fdb-kubernetes-operator icon indicating copy to clipboard operation
fdb-kubernetes-operator copied to clipboard

Check if the namespace is created by the same test suite

Open johscheuer opened this issue 1 year ago • 3 comments

Description

Prevent cases where two concurrent test suites will choose the same random namespace and cluster name. This change will make sure that only one test suite will take the namespace and the other test suite will generate a new random name. This will prevent cases where those two concurrent test suites use the same namespace, which will cause a failure of both test cases.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran a manual test (the test suite was picking the same namespace as I defined it with the according environment variable):

Operator Stress when creating and deleting a cluster multiple times should create a healthy and available cluster [e2e]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_stress/operator_stress_test.go:53
  2024/07/04 12:38:08 created namespace jscheuermann
  2024/07/04 12:38:09 namespace jscheuermann already in use by test suite: operator-test, current test suite: operator-stress
  2024/07/04 12:38:10 created namespace jscheuermann

Documentation

Follow-up

johscheuer avatar Jul 04 '24 10:07 johscheuer

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 7bc423e357000adeb18b8fcdc32fa7577835ef37
  • Duration 2:59:37
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 04 '24 13:07 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: aecee8f2a771a57bdd0f085995bb5188bf452f35
  • Duration 2:54:00
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 04 '24 15:07 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: aecee8f2a771a57bdd0f085995bb5188bf452f35
  • Duration 2:39:55
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 04 '24 17:07 foundationdb-ci

The test failures above were unrelated to this change.

johscheuer avatar Jul 05 '24 09:07 johscheuer

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: aecee8f2a771a57bdd0f085995bb5188bf452f35
  • Duration 2:34:28
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 05 '24 10:07 foundationdb-ci