fdb-kubernetes-operator icon indicating copy to clipboard operation
fdb-kubernetes-operator copied to clipboard

Make use of can clean bounce in bounce reconciler

Open johscheuer opened this issue 3 years ago • 1 comments

What would you like to be added/changed?

We should add support for the bounce_impact fields in the cluster status. If can_clean_bounce is false we shouldn't try to bounce the cluster. We probably want to have a setting to disable this check in a case where can_clean_bounce is reporting false but we still want the operator to do the bounce. Arguably if can_clean_bounce is false a human operator could still perform the bounce if required.

Status from: https://apple.github.io/foundationdb/mr-status.html:

   "bounce_impact":{
      "can_clean_bounce":true,
      "reason":""
   },

johscheuer avatar Sep 01 '22 13:09 johscheuer

For safety checks on bounces, I think it's generally OK to rely on manual bounces. It helps if we can have clear messaging on why the operator is not doing the bounce, including a list of processes that makes it easy for someone to do the bounce manually. The same likely applies to things like force exclusions or potentially unsafe database configuration changes.

brownleej avatar Sep 14 '22 23:09 brownleej

This was actually already implemented.

johscheuer avatar Feb 16 '24 13:02 johscheuer