fdb-kubernetes-operator icon indicating copy to clipboard operation
fdb-kubernetes-operator copied to clipboard

Initial support for server side apply

Open johscheuer opened this issue 3 years ago • 4 comments
trafficstars

Description

Add support for server side apply. Fixes: https://github.com/FoundationDB/fdb-kubernetes-operator/issues/1278

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

SSA is per default disabled and has to to enabled to use it.

Testing

I tested it in a dev cluster and ran the e2e test suite we have.

Documentation

Added in the help method of the operator.

Follow-up

Once the support for SSA in the controller-runtime is more mature we might change some things.

johscheuer avatar Aug 15 '22 16:08 johscheuer

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: dbceb42b710cf8654d7086517f87c12a4025d4b9
  • Duration 0:04:31
  • Result: :x: FAILED
  • Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 17:08 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: fa0951e4d26d225875be86973a194a936d91c61b
  • Duration 0:04:31
  • Result: :x: FAILED
  • Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 17:08 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 0bfe4673623bd57fe848baed3513ba7ef5d48e5a
  • Duration 0:04:56
  • Result: :x: FAILED
  • Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 18:08 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: d3be68b95f2da374c0df79245a41904620ca454a
  • Duration 0:04:29
  • Result: :x: FAILED
  • Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 15 '22 18:08 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: d3be68b95f2da374c0df79245a41904620ca454a
  • Duration 2:14:10
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 16:08 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: aff99eb620588a68cc247ee6f5a07cc41266dc0e
  • Duration 1:49:43
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 31 '22 14:08 foundationdb-ci

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: aff99eb620588a68cc247ee6f5a07cc41266dc0e
  • Duration 4:06:29
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 01 '22 10:09 foundationdb-ci

Discussed some concerns with @ltsampros offline and we agreed that the current setup is fine.

johscheuer avatar Sep 01 '22 12:09 johscheuer