fdb-kubernetes-operator
fdb-kubernetes-operator copied to clipboard
FoundationDB
Add a separate setting for enabling DNS names in pod locality
Description
Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.
This allows us to configure the pod spec aspects of the new DNS name support long before updating the cluster file itself, which should provide a smoother transition and easier testing of the conversion process.
Fixes #1230
Please select one of the options below.
- New feature (non-breaking change which adds functionality)
Discussion
Are there any design details that you would like to discuss further?
No.
Testing
Please describe the tests that you ran to verify your changes. Unit tests? Manual testing?
Manual testing.
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
No.
Documentation
Did you update relevant documentation within this repository?
Yes.
If this change is adding new functionality, do we need to describe it in our user manual?
No, I don't think so. It's fairly minor.
Follow-up
Does this introduce new defaults that we should re-evaluate in the future?
We may want to make this new setting default to true in the next major release.
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 41bf003babb4917c720f08678cf4e0d2aa407616
- Duration 0:03:02
- Result: :x: FAILED
- Error:
Error while executing command: make -C tests compile. Reason: exit status 2 - Build Logs (available for 30 days)
I think this just got lost in the noise when we shifted our focus onto stabilization last fall. I'll get this PR into a mergeable state.
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 60ddd1f5b46830108fb4d0855d9c03e7fac645fa
- Duration 2:34:29
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 9d438d4390215667df6a3f2c64d5beab9842e751
- Duration 2:31:24
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 9c89f1887eb7f574fdbdcf1863b9df208c848349
- Duration 2:36:42
- Result: :x: FAILED
- Error:
Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1 - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 435b5a8b002c56e18ec4a6f1fa63debcaf2827a9
- Duration 2:34:42
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 655df4cf564dcae16ccbc9420b78eb127b75620b
- Duration 3:12:30
- Result: :x: FAILED
- Error:
Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1 - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
- Commit ID: 655df4c
- Duration 3:12:30
- Result: ❌ FAILED
- Error:
Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1- Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
All tests passed except for one test, that failed with:
ERROR: This exclude may cause the total free space in the cluster to drop below 10%.\nType `exclude FORCE <ADDRESS...>' to exclude without checking free space.\n
This is a known issue that should be fixed soon.
