fdb-kubernetes-operator Generate initial cluster file doesn't honour coordinator selection

Generate initial cluster file doesn't honour coordinator selection

Open johscheuer opened this issue 3 years ago • 0 comments

What happened?

In the generate initial cluster file reconciler we only select storage Pods: https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/controllers/generate_initial_cluster_file.go#L47. Instead we should make use of the https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/api/v1beta1/foundationdbcluster_types.go#L3055-L3058 and filter all Pods out that are not valid coordinators. This is a rather small bug without a huge impact since we hit this case only when we create a new cluster and the side effect will be that we have potentially 2 coordinator changes instead one. For consistency we should fix this bug.

What did you expect to happen?

That the generate initial cluster file sub reconciler makes use of the coordinator selection mechanism.

How can we reproduce it (as minimally and precisely as possible)?

Create a new cluster and change and watch the logs (you can also change the default coordinator selection).

Anything else we need to know?