Voice-Recorder icon indicating copy to clipboard operation
Voice-Recorder copied to clipboard

Published 20 hours ago • verified publisher icon FossifyOrg

Changed default sampling rate (#32)

Open Aga-C opened this issue 1 year ago • 3 comments

What is it?

  • [X] Bugfix
  • [ ] Feature
  • [ ] Codebase improvement

Description of the changes in your PR

  • Changed default sampling rate from 44.1 kHz to 48 kHz, so there's no need to write any conditions to check for Opus.
  • Tested on real mobile and recording in 48 kHz works correctly for each of three file types.
  • I've also cross-tested with the released version and Opus now sounds as it should.
  • We can let users change to 44.1 kHz with implementing #33 in the future.

Fixes the following issue(s)

  • Fixes #32

Acknowledgement

Aga-C avatar Feb 26 '24 16:02 Aga-C

Any idea when this and https://github.com/FossifyOrg/Voice-Recorder/pull/36 will be merged?

David-Else avatar Apr 15 '24 18:04 David-Else

It should be merged before the release of the next version, but I can't tell you when exactly it will happen. Please wait patiently.

Aga-C avatar Apr 15 '24 18:04 Aga-C

This will work for now. I second the eagerness to see it released.

If anyone wondered, this behavior is because Opus does not support 44,100 at all, so it encodes the samples anyway but marks it as the nearest thing supported, 48,000.

SilverPuppy avatar Oct 01 '24 21:10 SilverPuppy

Thanks!

naveensingh avatar Jan 04 '25 12:01 naveensingh