Filenames get persisted to disk

[HolonProduction]

Checklist

• [X] I can reproduce the bug with the latest version given here.
• [X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• [X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• [X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• [X] This issue contains only one bug.
• [X] I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 14 / One UI 6

Affected device model

Samsung Galaxy A52s

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

1. Start from a clean app state (new installation which scanned the media)
2. Change the display filename setting to always
3. Create a new playlist
4. Open the all tracks playlist and add a track to the new playlist (the track should have track name available)
5. Change the display filename setting back if no title available
6. Open the created playlist

Expected behavior

The added song is displayed with its track name since it is available

Actual behavior

The added song is displayed using its filename

Screenshots/Screen recordings

No response

Additional information

The approach for implementing this display option is the problem here. It overwrites the title inside of the entity object after loading. If this entity is then resaved, the filename gets persisted and not the actual title.

In general, actions that don't alter a track shouldn't alter the entity object. A better approach would be an extension method on the entity which gets the filename to display.