Music-Player icon indicating copy to clipboard operation
Music-Player copied to clipboard

Add a separate icon for the shuffle button when in the "shuffled" state.

Open austinoneil opened this issue 1 year ago • 5 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • [X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • [X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X] This issue contains only one feature request.
  • [X] I have read and understood the contribution guidelines.
  • [ ] I optionally donated to support the Fossify mission.

Feature description

Add a separate icon for shuffle enabled and disabled.

Why do you want this feature?

It's difficult to tell when the current playlist is shuffled. Currently, a toast appears when shuffle is activated/deactivated, but if a user accidentally bumps the shuffle button, the user may find the next song is not what they wanted.

Additional information

No response

austinoneil avatar Apr 30 '24 14:04 austinoneil

Icon color changes when shuffle is enabled, what's rather a standard feature when comparing to other players. Can you give an example of a music player that changes icon and what icons should be used?

Aga-C avatar Apr 30 '24 14:04 Aga-C

I can imagine the primary color might not always be easily distinguishable from the grey-ish color for the disabled state. What if we used white/black color in dark/light themes instead of the primary color for the on state, would that be less confusing?

There is a 'Shuffle On' material icon but I don't think it'll mix well with the rest of the UI.

naveensingh avatar Apr 30 '24 15:04 naveensingh

Icon color changes when shuffle is enabled, what's rather a standard feature when comparing to other players. Can you give an example of a music player that changes icon and what icons should be used?

Naveen explained it well here.

austinoneil avatar Apr 30 '24 20:04 austinoneil

Definitely it needs a change - currently shuffle state is indistinguishable

michalkulik avatar Nov 12 '24 20:11 michalkulik

This was one of the first things I noticed on my first use of the app.

With the theme I was using (Material You), the shuffle state doesn't appear to change the color at all, so I couldn't determine the shuffle state visually and had to toggle shuffle to read the notification message. An icon change would have been helpful.

I have since switched to the Auto light/dark theme where that coloring problem isn't present.

AidanJHMurphy avatar May 03 '25 22:05 AidanJHMurphy