Music-Player icon indicating copy to clipboard operation
Music-Player copied to clipboard

Track number displays 0 despite metadata not set

Open tswistak opened this issue 1 year ago • 3 comments
trafficstars

Checklist

  • [X] I can reproduce the bug with the latest version given here.
  • [X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • [X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • [X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X] This issue contains only one bug.
  • [X] I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 13 (OxygenOS 13.1)

Affected device model

OnePlus 8 Pro

How did you install the app?

GitHub releases

Steps to reproduce the bug

  1. Have a file (format doesn't matter) without track number metadata (e.g. any WAV file, recordings from Voice Recorder, notification sounds from phone etc.)
  2. Go to albums tab
  3. Open album/directory with file from step 1

Expected behavior

If track number metadata is not set, it shouldn't be displayed at all.

Actual behavior

0 is displayed as a track number.

Screenshots/Screen recordings

Fossify Music Player showing an "album" with notification sounds from Slack app: fmp-0

Additional information

In my opinion, 0 isn't the same as no data provided, that's why it shouldn't be the default value.

tswistak avatar Apr 09 '24 14:04 tswistak

What about a '-' when there is no track number? Or maybe a '•'?

naveensingh avatar Apr 14 '24 17:04 naveensingh

Do as you think will look the best. However, I'm used to having nothing in such case. For example, that's how foobar2000 displays it: obraz As I remember, VLC for Android also shows nothing in this case.

tswistak avatar Apr 14 '24 18:04 tswistak

Nothing sounds good too. The start padding should be reduced a tiny bit so there isn't a lot of empty space in case of tracks with no metadata.

naveensingh avatar Apr 14 '24 18:04 naveensingh