Remove "Recycle bin" feature

[naveensingh]

Checklist

• [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• [x] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• [x] I have taken the time to fill in all the required details. I understand that the request will be dismissed otherwise.
• [x] This issue contains only one feature request.
• [x] I have read and understood the contribution guidelines.

Feature description

Remove the recycle bin feature.

Why do you want this feature?

The feature should be removed because:

• It only works with individual messages, not whole conversations.
• Adding support for deleting conversations would turn this feature into the "Archive" feature and we'll have two things doing the same with different names.
• Simpler code base, less potential for bugs.

Additional information

This might be a breaking change for some/many so it should probably be a part of version 2.0.0.

Related:

• https://github.com/FossifyOrg/Messages/issues/174#issuecomment-2585672053
• https://www.reddit.com/r/Fossify/comments/1i9e1wa/unable_to_move_messages_into_recycle_bin/

The archive feature is simple and enough for most use-cases, we could optionally add a 'Automatically delete archived messages after 30 days' option for those who want it to act like a recycle bin.

[s38b35M5]

~I would just ask to confirm that this message is correct before putting my full support behind this feature.~

Disregard

[MGidnian]

Will it retain the functionality of "archiving" a single message and not the whole conversation?

I see how for some conversations you would like to completely archive/hide the conversation. But another use case is: for many services/business - a common blocking use case it that you will get relevant messages (OTP, updates, etc) but will also get ads and other irrelevant messages in the same conversation.

To keep things clean and relevant - the best case scenario is to be able to archive/block/hide only certain messages but keep the rest in the inbox.

This functionality is supported today by the recycle bin, and also makes much sense for the keyword blocking mechanism in general.

[naveensingh]

Will it retain the functionality of "archiving" a single message and not the whole conversation?

No but keyword blocking + https://github.com/FossifyOrg/Messages/issues/59 should solve such usecases.

[vjadid]

I have a usecase of using Recycle bin. My bank app has aggressive data collection practices and it requires SMS read permission, else the app won't open. They provide the reason as " to read otp". They could have simply used the one time otp sms permission but that won't allow them to scrape all sms all the time.

So before using the app I delete all the sms (I only keep all sms for 1 week so total sms list is small) which sends it to recycle bin. then I allow bank app to read sms permission and use the app. Once I am done I revoke the sms permission from bank app and restore the sms from recycle bin.

In my previous testing archived sms still are readable by app having sms permission, but recyclebin sms are not.

[ecsghub]

hello. new to github. thx for the great app. Please do not get rid of the recycle bin. I agree with others and it seems a bit counterintuitive that you cannot move the whole conversation to the recycle bin. I get That you think the archiving function works fine for recycle bin, but I disagree. I think there will be plenty of times when I forget that and delete rather than the extra of putting it in the archive. But please don't remove the recycle bin altogether aas it's better with it as is, even if it doesn't function the way I'd like

[antodc]

I thought about this for a while, and in the end I think that the best solution would be the one mentioned by @naveensingh here: "We could do Archive for conversations only and Recycle bin for messages". In my opinion, there is no need to extend the Recycle feature to conversations, thus making it (more) similar to Archive. As explained clearly by @Aga-C here, it is already quite easy to delete/recycle all messages in a conversation. I understand that having Archive only would make the code simpler, but to me, from the perspective of the user, having both features would be really great.