Launcher
Launcher copied to clipboard
FossifyOrg
Make clicking on text launch app in home screen
What is it?
- [x] Feature
Description of the changes in your PR
- I made clicking on icon cell in home screen launch the app. Previously it was just the icon that had to be clicked + little margin.
- I replaced the deprecated constructor
BitmapDrawablewith the KTX extension functionBitmap.toDrawable
Fixes the following issue(s)
- Fixes #115
Acknowledgement
- [x] I read the contribution guidelines.
When I was testing I noticed that all app icons in home screen and app drawer were invisible for little time. That only happened when I launched the launcher for the first time. Is that related to #105?
What you're describing sounds related to https://github.com/FossifyOrg/Launcher/issues/21.
#105 is about a completely transparent drawer (not just the icons).
I assume you have tested this change properly?
I assume you have tested this change properly?
Yes, I tested it. When clicking on the area shown below the app starts
When clicking on the area shown below the app starts
Do you think that it needs modification?
It works but a little too well:
https://github.com/user-attachments/assets/94373797-c79b-4058-b408-fbfd8077cb87
I don't know how to obtain text height.
Maybe just multiply cellHeight by 0.7f?
Maybe just multiply cellHeight by 0.7f?
No. There are enough quick fixes in this app as it is.
Let's close this if you are unable to solve it. I'll check it later.
Thanks.
I came up with a solution. You can see it now. Clicking on home screen items whose label is a single line is the same as clicking on items whose labels are 2 lines. In summary, all items have the same click area.
https://github.com/user-attachments/assets/6b4311f3-dd91-4663-818d-3732e4802a82
The IDE was complaining about not using kotlin functions so I changed some functions to kotlin functions.
I forgot to test folder. Here it is.
https://github.com/user-attachments/assets/f64ba3db-646a-44a9-a202-6b6e8092165c