Gallery
Gallery copied to clipboard
Gallery issue 666
… 2x and reverts when hold gesture ends
Type of change(s)
- [ ] Bug fix
- [X] Feature / enhancement
- [ ] Infrastructure / tooling (CI, build, deps, tests)
- [ ] Documentation
What changed and why
- Added a listener that detects for touch and hold event to add a 2x playback speed runnable
Tests performed
Tested on Nothing Phone 2A and API 36.0 Emulator
Preview
https://github.com/user-attachments/assets/a9641f44-ff8e-4af5-bd53-5fa636a578ab
Closes the following issue(s)
- Closes #666
Checklist
- [X] I read the contribution guidelines.
- [X] I manually tested my changes on device/emulator (if applicable).
- [X] I updated the "Unreleased" section in
CHANGELOG.md(if applicable). - [X] I have self-reviewed my pull request (no typos, formatting errors, etc.).
- [X] All checks are passing.
- There's a separate player (
VideoPlayerActivity) that can be activated in app settings (Always open videos on a separate screen with new horizontal gestures). This functionality should also be added there (as long as it doesn't conflict with the seek gestures there)
@naveensingh the new player uses long press gesture to skip the video forward/backward so not sure how we could integrate this long press 2x playback speed feature into the other player
We could increase the speed as long movement is smaller than the touch slop, but it's a nice-to-have. Not necessary for this PR.
I have implemented that pill shaped representation of the 2x playback speed long press feature just like Youtube app.
- Increase volume/brightness using vertical gestures ➜ move the touch pointer to the center of the screen without lifting it ➜ playback speed is set to 2x and it shouldn't be (this is a minor issue)
This one I tried to fix, but I think it's not fixed completely, will take another jab at it.
It mostly works, but there are some issues:
Pinch to zoom ➜ playback speed is permanently set to 2x
- Long press ➜ playback speed is set to 2x ➜ perform pinch to zoom without lifting the initial/first touch pointer ➜ playback speed is permanently set to 2x
Increase volume/brightness using vertical gestures ➜ move the touch pointer to the center of the screen without lifting it ➜ playback speed is set to 2x and it shouldn't be (this is a minor issue)
There's a separate player (
VideoPlayerActivity) that can be activated in app settings (Always open videos on a separate screen with new horizontal gestures). This functionality should also be added there (as long as it doesn't conflict with the seek gestures there)Additional suggestion:
The playback speed button already reflects the speed in the standard case, but it would be nice to show a
2x>>pill at the top when speed is boosted in full-screen mode. You can check YouTube to see how that works.
@naveensingh 1,2 and 2x playback pill implementation is done. Please review.