No rotation by aspect ratio in slideshow when animation = none

[ltguillaume]

Checklist

• [x] I can reproduce the bug with the latest version given here.
• [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• [x] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• [x] This issue contains only one bug.
• [x] I have read and understood the contribution guidelines.

Affected app version

1.4.1-1.5.1

Affected Android/Custom ROM version

Android 14-16

Affected device model

All

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

1. Settings > Fullscreen media > Rotate fullscreen media by: Aspect ratio
2. Start slideshow

Expected behavior

Images should rotate according to aspect ratio.

Actual behavior

There is no rotation at all.

Screenshots/Screen recordings

No response

Additional information

Related: #417

[litoj]

For me rotation by aspect ratio doesn't work at all anymore since the last two latest versions.

[ltguillaume]

Updated my findings with v1.4.2 compared to v1.4.1.

[Aga-C]

@ltguillaume Please check this with the latest version.

[ltguillaume]

@ltguillaume Please check this with the latest version.

Ah right, those are reproducible builds on F-Droid, so I can update.

Result in 1.5.1: same as v1.4.2 (see Actual behavior).

[Aga-C]

I can only reproduce this behavior with animation set to None (both on 1.4.2 and 1.5.1). For other values, the only issue is screen rotating after the second image, which is already raised in a separate issue: https://github.com/FossifyOrg/Gallery/issues/417.

[ltguillaume]

I can only reproduce this behavior with animation set to None (both on 1.4.2 and 1.5.1). For other values, the only issue is screen rotating after the second image, which is already raised in a separate issue: #417.

Agreed, I forgot about #417 for a minute, since this issue is also quite old. So just like you said, this issue is explicitly about the lack of rotation when animation is set to none.

For me rotation by aspect ratio doesn't work at all anymore since the last two latest versions.

@litoj Do you mean with slideshow+animation as well, or maybe when just viewing fullscreen (without slideshow)?

[litoj]

@ltguillaume my issue is in general when viewing in fullscreen. I noticed it is dependent on the extension of the viewed file. JPG works just fine, but JXL and AVIF get simply displayed in the current orientation, even if they should get rotated.

[Aga-C]

@litoj That's a completely different issue. Please report it as a new bug.