[fr] mute videos

[throwaway242685]

Checklist

• [X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• [X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• [X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• [X] This issue contains only one feature request.
• [X] I have read and understood the contribution guidelines.
• [ ] I optionally donated to support the Fossify mission.

Feature description

there should be an option, something like "Mute videos", to be able to play videos without sound.

Why do you want this feature?

pretty much every player has something like this.

Additional information

No response

[naveensingh]

I think this belongs in the player control UI, not the settings.

[throwaway242685]

sorry for bumping this up, but are there any plans for this?

[naveensingh]

Yes, it'll likely be added in the next release (whenever that is).

[naveensingh]

Added a simple mute button. Like the volume control gesture, the mute button directly affects and is in sync with the system music stream volume.

[tswistak]

the mute button directly affects and is in sync with the system music stream volume.

@naveensingh Why? I just tested the newly released version, and this behavior is very counterintuitive, I don't know any other app that works like this. All players that I know mutes only on their level, not on the whole system. What's worse, unmuting brings system volume to 100%. I wanted to raise it as a bug, but found this comment, and I'm a bit confused.

[naveensingh]

I assumed people might be accustomed to that because the volume control gesture works similarly. I don't use VLC much but volume control there is also linked with system.

Linking the system volume and player volume allows us to properly update the UI when you change/mute volume using system wide options like the hardware volume keys.

[throwaway242685]

I don't know if that's a technical limitation of the old code of Simple Gallery, but Next Player can mute videos without muting the whole system.

the volume there is also linked to the system volume, as far as I know.

when I suggested this feature I actually did it on favor of listening to music in the background while watching videos :) so, yeah... I also think that the mute feature should be only at app level, not at system level.

[naveensingh]

Alright, it'll be fixed in the next update.

[naveensingh]

Case	Default Behavior	Linked Behavior
1. Volume changes while player is muted	Player remains muted	Unmute player?
2. Volume increases from zero while player is muted	Player remains muted	Unmute player
3. Volume set to zero while player is not muted	Player remains unmuted (no sound)	Player is muted

I'm going with the default behavior.

[throwaway242685]

it would be great if the muting feature was persistent.

e.g. next time that you open a video, it should remember if the player was muted or not, and then use that.

[naveensingh]

yeah, it'll be persistent.