File-Manager icon indicating copy to clipboard operation
File-Manager copied to clipboard

Add option to use compressed file without extracting it

Open BastosLaG opened this issue 1 year ago • 2 comments
trafficstars

What is it?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Codebase improvement

Description of the changes in your PR

  • Add option to use compressed file inside the zip file without extracting it eg, If I compressed a video then I view video without extracting like in zarchiver

Fixes the following issue(s)

  • Fixes # https://github.com/FossifyOrg/File-Manager/issues/92

Acknowledgement

BastosLaG avatar May 16 '24 11:05 BastosLaG

Thanks to my colleague @PAxitoo for the participation.

BastosLaG avatar May 16 '24 12:05 BastosLaG

The main feature seems to work fine, but I see few issues around it:

  • Every text displayed to user should be in strings.xml, so it can be translated to other languages. Never hardcode them.
  • When I enter a zip file, it's not shown on the breadcrumbs.
  • When I want to go out from the zip, when I press the device's back button, it doesn't return to the previous folder but level above.
  • After entering the zip, in three dots menu there should be an option to unpack the file.
  • Adding to favorites and setting as parent directory should be hidden inside the zip.
  • Changing view type, sorting and showing hidden files shouldn't close the zip file.
  • When you select a file, none of the actions are working. They either throw exceptions or do nothing. IMHO, to make your lives easier, you can just hide these actions, since making them work would be another large feature.

Aga-C avatar May 16 '24 15:05 Aga-C

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.

fossifybot-legacy avatar Dec 17 '24 01:12 fossifybot-legacy