Add a relative brush size option

[CactiChameleon9]

trafficstars

What is it?

• [ ] Bugfix
• [x] Feature
• [ ] Codebase improvement

Description of the changes in your PR

Relative brush sizing (to zoom) can be annoying/difficult in certain situations, such as when trying to draw a picture with consistent line width.

This PR adds an option to disable relative brush size (enabled by default to preserve normal behaviour)

Acknowledgement

• [x] I read the contribution guidelines.

[inson1]

@CactiChameleon9 I really like this idea, It was my problem too, but maybe that should be optional? Opt out? As I can see some people could like it. What do you think? And everybody else?

[Aga-C]

@inson1 It is optional.

[naveensingh]

Hey, I'll merge it soon.

Thanks for resolving the conflicts.

[CactiChameleon9]

This needs retesting, but I don't think there are any changes from last time (no idea why there were conflicts, it was a copy paste job to current master)

[naveensingh]

no idea why there were conflicts

The package name was changed to org.fossify.paint before the release. See news.

[CactiChameleon9]

Tested and working fine. I was using a checkbox for the setting instead of toggle, now fixed. Should be ready to merge

[naveensingh]

Use a relative (to zoom) brush size

Naming this option must have been hard :)

I don't do much painting so I can't decide whether this option should be on or off to preserve the default behavior. If you look at it from the screen's frame of reference, the current behavior is to use a constant brush size (in pixels) but if you look at it from canvas's frame of reference, current behavior is relative to zoom level.

Suggestions (cleaner but there's still ambiguity):

• Use constant brush size on canvas (disabled by default)
• Adjust brush size based on zoom level (enabled by default)

What do you think?

[CactiChameleon9]

I think I prefer "Adjust brush size based on zoom level", it's unclear what a not-constant size would be.

I'll admit... I was expecting feedback on the naming :sweat_smile:

I personally am not really a fan of the default behavior, I find it disruptive with both note-taking and drawing because there is no way to move about without zooming accidentally. However, I recognize that it my be preferable to some and changing the behavior of an app is a pain (hence I left it as the previous behavior by default)

[naveensingh]

"Adjust brush size based on zoom level" works for me, let's do that.

I personally am not really a fan of the default behavior, I find it disruptive with both note-taking and drawing because there is no way to move about without zooming accidentally.

Both have their pros and cons but yeah, preserving the default is usually the right choice. Come to think of it, there should be a reset zoom button somewhere in the app to solve that zoom issue.