FossifyOrg
Use of TYPE= parameter?
Checklist
- [x] I can reproduce the bug with the latest version given here.
- [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- [x] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- [x] This issue contains only one bug.
- [x] I have read and understood the contribution guidelines.
Affected app version
v.1.2.2
Affected Android/Custom ROM version
GrapheneOS
Affected device model
Pixel 8
How did you install the app?
GitHub releases
Steps to reproduce the bug
On the suggestion of @naveensingh , here, I'm moving part of this discussion, here:
Going to vCard Elements in IANA, I see that TYPE= parameter can have only a limited set of values. eg. for the EMAIL property, it's only "work" and "home". Fossify appears to be using TYPE="any string", as you see above. Is there some spec conformant way of doing this properly? Besides IANA, these appear to be the relevant RFC's. Please let me know if I've missed anything:
4.0: https://datatracker.ietf.org/doc/html/rfc6350 4.0, Format Extension: https://www.rfc-editor.org/rfc/rfc6715.html 4.0 extension for character escaping; https://datatracker.ietf.org/doc/html/rfc6868 4.0 extension for JSContact: https://datatracker.ietf.org/doc/html/rfc9554
As a comparison, this is how the Stock AOSP contacts app present it, using "X-Landline" for example.
BEGIN:VCARD
VERSION:2.1
N:Last;First;Middle;Pre;Suffix
FN:Pre First Middle Last, Suffix
X-PHONETIC-FIRST-NAME:PFirst
X-PHONETIC-MIDDLE-NAME:PMiddle
X-PHONETIC-LAST-NAME:PLast
TEL;HOME:+1-510-555-6666
TEL;X-Landline:555-1215
X-ANDROID-CUSTOM:vnd.android.cursor.item/nickname;Nickname;1;;;;;;;;;;;;;
EMAIL;HOME:[email protected]
ADR;X-Home:;;300 Amsterdam Av., New York, NY 10027-2819;;;;
ADR;X-Custom-Label:;;300 Amsterdam Av., New York, NY 10027-2819;;;;
ORG:Company\;Department
TITLE:Title
URL:http://www.foobar.com
NOTE;ENCODING=QUOTED-PRINTABLE:=4E=6F=74=65=73=20=6C=6F=63=61=74=65=64=0A=48=65=72=65=21
END:VCARD
Expected behavior
Spec conformant.
Actual behavior
Non-spec conformant.
Screenshots/Screen recordings
No response
Additional information
No response
v 1.3.0 (source f-droid) does not have the TYPE "home" or "work" in the URL property resulting when importing a vcard 4.0 to show URL's without TYPE and when exporting a vcard 4.0 having no TYPE in the URL property.
I believe that issue is related to this thread.
@NATJDTD / I mention that in this issue. There's a discussion, and then, #2 near the bottom of the OP:
- Allow adding websites to a vCard, with custom labels. Note that the TYPE= schma is available in vCard 4.0 for URL. See the RFC.
@NATJDTD / I mention that in this issue. There's a discussion, and then, #2 near the bottom of the OP:
- Allow adding websites to a vCard, with custom labels. Note that the TYPE= schma is available in vCard 4.0 for URL. See the RFC.
You're absolutely right! Beginner's mistake, sorry!
You're absolutely right! Beginner's mistake, sorry!
Not a mistake I ever made (make). 😉