Some Contacts are filtered out and some sources does not appear

[andrew-2e128]

Checklist

• [x] I can reproduce the bug with the latest version given here.
• [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• [x] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• [x] This issue contains only one bug.
• [x] I have read and understood the contribution guidelines.

Affected app version

1.1.0

Affected Android/Custom ROM version

Android 12

Affected device model

• Realme 7 Pro (RMX2170)

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

I have no clue how it happened, but it happened on it's own in SMT contacts then still exists in fossify

Expected behavior

Contacts not being hidden

Actual behavior

• Contacts are filtered out incorrectly but they are still stored

Screenshots/Screen recordings

No response

Additional information

I have tracked the issue down for a bit, basically this line filters the contacts by source

https://github.com/FossifyOrg/Contacts/blob/13c1b51e737e3f52d8bf58d198d1836e30ea93bf/app/src/main/kotlin/org/fossify/contacts/fragments/MyViewPagerFragment.kt#L143

the issue is sometimes the it.source is empty string and it filters for "Phone"

[andrew-2e128]

I tried doing this:

contacts.filter { if (it.source.isEmpty()) contactSources.contains("Phone") else contactSources.contains(it.source) }

instead of the line above and it worked (also note this does not fix their count in the source selection dialog)

I am not familiar with this stuff, should it.source never be empty string?

[andrew-2e128]

Update,

https://github.com/FossifyOrg/Commons/blob/14a2a455809dd8a202d0c159c977aac846a8dadf/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L837-L843

I think this might be related to the issue

so here are my problems so far

• Google account does not appear as a source
• I have both the empty account and the Phone account and both have contacts
• the Empty account contacts are not appearing

The lines above do all this filtering

[Aga-C]

Even though you have found the source of the bug, it sounds device/software specific, so please fill out the issue template properly. All fields are required because we'd like to have information in them that helps identify a bug, not -.

[andrew-2e128]

Added the required information

Also for some reason while I was messing around with telegram settings the issue fixed itself somehow,

I ran a debug build to see what is different,

https://github.com/FossifyOrg/Commons/blob/14a2a455809dd8a202d0c159c977aac846a8dadf/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L836

basically now I no longer have "telegram" in allAccounts and no longer have the "Phone" account, just the empty account, interestingly the contacts that were in "Phone" are now gone

I don't remember how I added those contacts (but it is one of whatsapp, phone, contacts apps)

technically the issue is solved for me -for now-

also google account still not visible (it shows in allAccounts tho)

[naveensingh]

also google account still not visible (it shows in allAccounts tho)

But is it visible in Google Contacts app or any other contacts app?

[andrew-2e128]

for some reason they don't appear in "Connect You" contacts app, but they appear in the stock (Google Contacts) app

I don't remember if they appeared before recently, but I remember SMT reading such source before

[Dark-Aeon]

I have a similar issue with the Contacts App i noticed it today.

Some contacts dont show up in the Fossify Contacts App but show up in the Contact app my Phone came with. creating a contact with Fossify can be seen in both contact apps. Creating it with the Contact app the phone came with, Fossify cannot see it and if i create a Contact from an number that has called me both apps can see the contact.

Fossify Contacts Version: 1.3.0

Android Version 16, GrapheneOS

Pixel 7 device.

[markbourne]

I didn't realise when posting a follow-up on #423 that it had been closed. In case you don't see the comment there and in case it's relevant:

Ahh, progress - It does seem to be some interaction with WhatsApp! I uninstalled that, and now Fossify Contacts shows a filter for "Phone storage" instead of "Phone", and all the original contacts are shown.

The new contact that I'd added using Fossify Contacts under "Phone" (as per my previous comment) is now gone from both Fossify Contacts and the default Contacts app. The default app also no longer shows a "Phone" filter, only "Device". I can live with that, although it might have been annoying if I'd added a lot of other contacts before noticing the problem.

As I mentioned, I'm sure non-WhatsApp contacts were originally still shown in Fossify Contacts after installing WhatsApp, but perhaps an update to WhatsApp has caused the problem...

Subsequently reinstalling WhatsApp, Fossify Contacts still shows "Phone storage" instead of "Phone" and all previous contacts are still visible. Fossify no longer lists WhatsApp in its filters (I had thought it would return), but that doesn't bother me. Maybe it will reappear at some point - if I notice it does I'll look out for whether other contacts also disappear again.

[Edit: To clarify, after reinstalling WhatsApp the phone contacts are shown, although no WhatsApp contacts, using Fossify Contacts 1.3.0 and 1.4.0 APKs and also 1.4.0 from Google Play. Contacts are also now shown in Fossify Phone, which has been version 1.9.0 from Google Play throughout all the above, I hadn't switched versions of Phone.]

[markbourne]

...and adding a contact from within WhatsApp, selecting to save to "Phone" from there (the only other option is the email address I use for Android), causes the problem to recur - Fossify Contacts now shows "Phone" instead of "Phone storage" in its filters, and also a filter for "WhatsApp", and all the original contacts are gone again.

It was only recently that I first added a new contact within WhatsApp, which will be why I hadn't previously had any problem with contacts since installing WhatsApp.

[andrew-2e128]

a workaround I use currently is just isolating everything completely, whatsapp, telegram, etc does not store into phone, all phone numbers are stored in "Phone storage (not visible to other apps)"