Commons icon indicating copy to clipboard operation
Commons copied to clipboard
verified publisher icon FossifyOrg

Fix FossifyOrg/Phone#28 (Missing contacts)

Open czarnyckm opened this issue 1 year ago • 4 comments

Fix FossifyOrg/Phone#28 (Missing contacts) According to doc ContentResolver.getIsSyncable returns value >0 if it is syncable, 0 if not, and <0 if the state isn't known yet. see also https://github.com/FossifyOrg/Phone/issues/28#issuecomment-1938635900

What is it?

  • [x ] Bugfix
  • [ ] Feature
  • [ ] Codebase improvement

Description of the changes in your PR

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

Fixes FossifyOrg/Phone#28

Relies on the following changes

Acknowledgement

czarnyckm avatar Jun 28 '24 13:06 czarnyckm

Fixes https://github.com/FossifyOrg/Phone/issues/28 and fixes https://github.com/FossifyOrg/Contacts/issues/83.

Aga-C avatar Jun 28 '24 13:06 Aga-C

imho this is an important fix, because the app it not usable without. When will it be merged? What is the reason that it is not merged yet? Is there anything that needs to be done? I did not find anything about the procedures in the repo.

Honk2 avatar Aug 06 '24 20:08 Honk2

I agree. Is testing needed for this to be merged? In that case I would be open to test if someone could provide the apk.

Kasi07 avatar Aug 08 '24 15:08 Kasi07

Unfortunately I haven't had the time to work on this and some other important issues in Fossify (got super busy recently with some personal but unexpected matters). Hopefully I'll have some time for work after the weekend.

naveensingh avatar Aug 09 '24 19:08 naveensingh

I fix the check ContentResolver.getIsSyncable(it, AUTHORITY) > 0

czarnyckm avatar Aug 26 '24 12:08 czarnyckm

@naveensingh can you review and merge it please? I cannot use the app for months…

jrd avatar Aug 30 '24 06:08 jrd

I'm aware that this is an important issue for many but I'm currently stuck in a hospital. I'll try to release an update as soon as I have some free time.

naveensingh avatar Aug 30 '24 08:08 naveensingh

Ok I understand, thank you for the quick answer.

jrd avatar Aug 30 '24 08:08 jrd

@naveensingh Your wellbeing always comes first. Take all the time you need, but still get better soon ❤️❤️❤️

Groctel avatar Aug 30 '24 08:08 Groctel

Apparently, getIsSyncable() returns 0 i.e. NOT_SYNCABLE when Google Play Services is disabled.

naveensingh avatar Sep 03 '24 12:09 naveensingh

That would explain the loosy doc (and variable name). It has meaning only if you have the Google Play Service running.

cpontvieux-systra avatar Sep 03 '24 15:09 cpontvieux-systra