Commons icon indicating copy to clipboard operation
Commons copied to clipboard

improve breadcrumbs

Open connyduck opened this issue 1 year ago • 3 comments
trafficstars

The breadcrumbs have several problems,

  • the background color and the actived state are wrongly set
  • on long paths the texts overlap
  • the code is more complicated than necessary

This PR solves all these problems and additionally improves the design by getting rid of the outline of the first item and using an actual icon instead of >.

What is it?

  • [x] Bugfix
  • [x] Feature
  • [x] Codebase improvement

Before/After Screenshots

Fixes the following issue(s)

Fixes https://github.com/FossifyOrg/Gallery/issues/208

connyduck avatar May 01 '24 18:05 connyduck

It also fixes FossifyOrg/General-Discussion#73.

Aga-C avatar May 01 '24 19:05 Aga-C

I'll check this soon.

From the screenshot, the 'Internal' part doesn't look like a button anymore, it should look like a button because it is the only way (to be revisited) to switch between "Internal", "SD Card", and other available storage volumes.

naveensingh avatar May 01 '24 19:05 naveensingh

It looks somewhat odd as a button, also the behavior is different to all other elements of the crumb, where tapping the element redirects to the corresponding folder. In case there is no second drive, it should act as all other parts. Maybe it is possible to find a different indicator for this duo-action element.

KOTRET avatar May 03 '24 18:05 KOTRET

@connyduck can you restore the outline on the first button until we have a better way to navigate between storage volumes?

naveensingh avatar Oct 27 '24 09:10 naveensingh

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.

fossifybot-legacy avatar Nov 19 '24 01:11 fossifybot-legacy

Stupid bot, I was still going to work on this

connyduck avatar Nov 19 '24 07:11 connyduck

Also, the first/storage button is no longer sticky, is that a good idea?

Update: It's probably not a good idea.

naveensingh avatar Jan 06 '25 18:01 naveensingh

I'll check this soon.

I should probably stop saying that.

I had to fix a couple issues but this is still better than before, thanks!

naveensingh avatar Jan 09 '25 13:01 naveensingh