Clock icon indicating copy to clipboard operation
Clock copied to clipboard

Snooze not working in landscape

Open Shadow-of-eagle opened this issue 1 year ago • 1 comments

Checklist

  • [X] I can reproduce the bug with the latest version given here.
  • [X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • [X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • [X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X] This issue contains only one bug.
  • [X] I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 8.1.0

Affected device model

Sony Xperia L3

How did you install the app?

Google Play Store

Steps to reproduce the bug

  1. Set an alarm
  2. When it goes off, rotate the device to landscape orientation
  3. Swipe to select snooze

Expected behavior

Snooze

Actual behavior

If in Landscape, the alarm just gets disabled, no matter wich option is selected. If the device is rotated back to portrait orientation, bevore seting the alarm to snooze, it works as expected.

Shadow-of-eagle avatar Aug 02 '24 13:08 Shadow-of-eagle

I can replicate this bug.

Just to clarify: "the alarm just gets disabled" (in landscape) means, that the phone does not ring again after a few minutes (= "snoozing"). Instead nothing happens. This is the same as if the user swiped to the right to "Dismiss" an alarm.

app version 1.0.0 Android version 13 6.A.029.0 device = Fairphone 3+ How did you install the app? Google Play Store

TheRupp avatar Aug 17 '24 19:08 TheRupp

This is happening to me as well. As soon as I start to swipe either left or right the alarm goes away and is not snoozed.

bobwms325 avatar Nov 19 '24 05:11 bobwms325

Hello, I'm a young developer looking for my first issue to learn how to contribute to an open-source project.

I tested this bug with the latest version of the GitHub project on the Android Studio emulator (Medium Phone, API 35), and it seems that the bug is resolved. The alarm appears to work correctly after I snooze it and rotate the screen to landscape.

Did I test it correctly, or did I make a mistake?

Bigorthebest avatar Jan 30 '25 09:01 Bigorthebest

The alarm appears to work correctly after I snooze it and rotate the screen to landscape.

Read once again the steps to reproduce.

Aga-C avatar Jan 30 '25 09:01 Aga-C

https://github.com/user-attachments/assets/86aa4818-ed3c-44b8-9cc5-f3dee905a96f

Maybe I'm just doing it wrong ? Or it's because I'm using an emulator (Medium Phone, API 35) ?

Bigorthebest avatar Jan 30 '25 10:01 Bigorthebest

The original issue is about full screen alarms where as in your video I only see a notification. Try turning off the display using power button after setting your alarm.

naveensingh avatar Jan 30 '25 10:01 naveensingh

Reproduction steps clearly say about "swiping", not about clicking on notification.

If you aren't familiar with the app to the point that you can properly understand reproduction steps, you shouldn't work on fixing the bug.

Aga-C avatar Jan 30 '25 10:01 Aga-C

Okay i got it now, i had to use the power button after setting my alarm to reproduce the bug. Sorry for the confusion but English isn't my first language and i had trouble figuring out what "swiping" meant in that context.
Thanks for the help, I still want to try to work on it if its okay.

Bigorthebest avatar Jan 30 '25 10:01 Bigorthebest

I edited the steps to reproduce, to make it more clear, what to do and avoid further missunderstandings. Don't worry about the language, English is not my native language either.

Shadow-of-eagle avatar Jan 30 '25 13:01 Shadow-of-eagle

Hello again,

I created a pull request that attempts to fix the bug by preventing the activity from rotating when the alarm rings.

I understand that this may not be the expected solution, but I would like to hear your opinion. I'm a computer science student trying to improve myself. Thank you for your patience.

Bigorthebest avatar Feb 20 '25 13:02 Bigorthebest

preventing the activity from rotating when the alarm rings. I understand that this may not be the expected solution, but I would like to hear your opinion.

Yes, that's not the right way to solve this.

naveensingh avatar Feb 20 '25 14:02 naveensingh

Hello again, I made a new and more conventional solution for the issue ! I'm ready to upgrade my pull request if you have any recommendation to help me improve.

Bigorthebest avatar Mar 06 '25 10:03 Bigorthebest

Thanks! I'll check it soon...

naveensingh avatar Mar 06 '25 10:03 naveensingh