Clock icon indicating copy to clipboard operation
Clock copied to clipboard

FEAT: added Sorting dialog to the timer tab

Open ronniedroid opened this issue 1 year ago • 7 comments

What is it?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Codebase improvement

Description of the changes in your PR

  • Added a dialog for sorting timers by creation time or timer duration
  • added config entries for timer sorting order
  • updated the menu accordingly
  • Update strings

Before/After Screenshots/Screen Record

  • Before:

  • After:

Fixes the following issue(s)

  • Fixes #7 but the sorting by timer duration is not set as the default option, to keep it the same as the alarms default.

Acknowledgement

ronniedroid avatar Apr 21 '24 10:04 ronniedroid

Compare your solution to what's already in Alarms, because it behaves a bit differently:

  1. If you have many timers, that they don't fit on screen, sorting scrolls view to the bottom. It doesn't happen in Alarms.
  2. There's an animation with timers moving around. In Alarms there's no animation.

Aga-C avatar Apr 22 '24 08:04 Aga-C

My PR did not add those, they were already there, I just added sorting.

ronniedroid avatar Apr 22 '24 09:04 ronniedroid

But there was no sorting before, so no one could see this behavior. I know you've just added sorting, but while adding a new feature, we should make sure that it behaves the same as in other places.

Aga-C avatar Apr 22 '24 10:04 Aga-C

But there was no sorting before, so no one could see this behavior. I know you've just added sorting, but while adding a new feature, we should make sure that it behaves the same as in other places.

Should I add animation to the alarms or remove it from the timers?

ronniedroid avatar Apr 22 '24 12:04 ronniedroid

Don't add animation and remove it from Timers. We don't have animations while sorting in other apps.

Aga-C avatar Apr 22 '24 13:04 Aga-C

@Aga-C I managed to remove the animation, but the auto scrolling I haven't figured out yet, I will try again later, but though I will say it here and maybe someone can share a tip or an idea.

ronniedroid avatar Apr 25 '24 11:04 ronniedroid

I move to MyRecyclerViewAdapter for the TimerAdapter to be consistent with the AlarmsAdapter, no visual changes, but now we have no animations and the list does not scroll to the bottom.

ronniedroid avatar Apr 28 '24 08:04 ronniedroid

I move to MyRecyclerViewAdapter for the TimerAdapter to be consistent with the AlarmsAdapter, no visual changes, but now we have no animations and the list does not scroll to the bottom.

Reverting because animations will be added everywhere. I'll fix the scrolling issue and 'add' the animation in alarms.

naveensingh avatar Feb 08 '25 19:02 naveensingh