FossifyOrg
Bank holidays are incorrectly listed under public for all countries
Checklist
- [x] I can reproduce the bug with the latest version given here.
- [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- [x] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- [x] This issue contains only one bug.
- [x] I have read and understood the contribution guidelines.
Affected app version
Affected Android/Custom ROM version
Affected device model
How did you install the app?
None
Which calendar service or provider do you use, if any?
No response
Which sync adapter app do you use for calendar synchronization, if any?
No response
Steps to reproduce the bug
All countries are currently displaying these observances as public holidays even if they are not public holidays in all countries:
- Christmas Eve
- Midsummer Eve
Expected behavior
I'm a native swede. Example for Sweden:
- Julafton (Christmas Eve)
- Midsommarafton (Midsummer Eve)
Should be listed in app/src/main/assets/holidays/SE/other.ics
Actual behavior
I observed that currently app/src/main/assets/holidays/SE/public.ics contain observances that are not public holidays:[1]
- Julafton (Christmas Eve)
- Midsommarafton (Midsummer Eve)
Screenshots/Screen recordings
No response
Additional information
The Fossify Calendar holiday data utilizes this repository (commenthol/date-holidays) to generate ICS files.
As pointed out by commenthol:
- Midsommarafton is a "bank" holiday, not public. See https://github.com/commenthol/date-holidays/blob/master/test/fixtures/SE-2025.json#L178
- Julafton is also a "bank" holiday. https://github.com/commenthol/date-holidays/blob/master/test/fixtures/SE-2025.json#L250
References
- According to the Swedish Parliament (Riksdag), the legal document Lag (1989:253) om allmänna helgdagar does not list:
- Julafton
- Midsommarafton
This affects all countries. Please consider updating the report to be more general.
This affects all countries. Please consider updating the report to be more general.
Done
Christmas Eve, and Midsummer Eve are incorrectly listed in public.ics for all countries
In Poland, Christmas Eve is a public holiday. It shouldn't be moved from public.ics.
In Poland, Christmas Eve is a public holiday. It shouldn't be moved from public.ics.
That's likely also true in the source metadata, so it will stay in public.ics. I had grouped bank holidays under public to keep 3 buckets, but I'm now thinking bank holidays should be offered as a separate category.
https://github.com/FossifyOrg/Calendar/blob/ecd3ca4c65217f3e72c35dc0656228a12638e417/.github/workflows/holiday-generator/config.js#L90-L91