Calendar icon indicating copy to clipboard operation
Calendar copied to clipboard

Published 20 hours ago • verified publisher icon FossifyOrg

Add Hong Kong Holiday

Open amalgame21 opened this issue 6 months ago • 3 comments

Checklist

  • [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • [x] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • [x] I have taken the time to fill in all the required details. I understand that the request will be dismissed otherwise.
  • [x] This issue contains only one feature request.
  • [x] I have read and understood the contribution guidelines.

Feature description

Add Hong Kong Holiday.

Why do you want this feature?

The following Hong Kong Holiday .ics files links come from government website. The URL haven't been changed for decades, and the content update every year.

https://www.1823.gov.hk/en/hong-kong-public-holidays-ical

(English) https://www.1823.gov.hk/common/ical/gc/en.ics (Traditional Chinese) https://www.1823.gov.hk/common/ical/gc/tc.ics (Simplified Chinese) https://www.1823.gov.hk/common/ical/gc/sc.ics

Average person in Hong Kong probably use the Traditional Chinese one, but I am not sure if only adding HK folder with public.ics and modifying the metadata.json is enough. I can do a pull request if someone can give me some assistant.

Additional information

The HK in https://github.com/commenthol/date-holidays is broken, so better not use it for now.

amalgame21 avatar May 12 '25 06:05 amalgame21

The HK in commenthol/date-holidays is broken

Do you have any specifics? It is preferred that updates/fixes are raised directly there so it helps everyone and requires less maintenance here.

Average person in Hong Kong probably use the Traditional Chinese one, but I am not sure if only adding HK folder with public.ics and modifying the metadata.json is enough.

There is some info regarding adding holidays at https://github.com/FossifyOrg/Calendar/blob/master/CONTRIBUTING.md#contributing-holidays.

If you have any more questions, let me know.

naveensingh avatar May 12 '25 06:05 naveensingh

Thanks for your advice! Now just wait for this to be merged!

amalgame21 avatar May 13 '25 07:05 amalgame21

upstream merged, thanks!

amalgame21 avatar May 15 '25 08:05 amalgame21

Good to know. We can include HK as soon as your new changes land in the next date-holidays release.

naveensingh avatar May 17 '25 02:05 naveensingh

Upstream have a new release. https://github.com/commenthol/date-holidays/releases/tag/v3.24.4

amalgame21 avatar Jun 15 '25 06:06 amalgame21

A test build will soon be available under https://github.com/FossifyOrg/Calendar/pull/646/checks

EDIT: https://github.com/FossifyOrg/Calendar/actions/runs/15660303665/artifacts/3330233496

naveensingh avatar Jun 15 '25 06:06 naveensingh

The above 2nd link test build is still using the data of date-holidays from v3.24.3 but thats ok I just wait for the Calendar's next release

amalgame21 avatar Jun 15 '25 09:06 amalgame21

It looks like the new version isn't published yet: https://www.npmjs.com/package/date-holidays

naveensingh avatar Jun 15 '25 10:06 naveensingh

Calendar's next release

It's up now: https://github.com/FossifyOrg/Calendar/releases/tag/1.4.0

naveensingh avatar Jul 05 '25 14:07 naveensingh