arduino_midi_library icon indicating copy to clipboard operation
arduino_midi_library copied to clipboard

NRPN/RPN Conflict?

Open matthew-a-dunlap opened this issue 6 years ago • 0 comments

I'm facing a bug with using both NRPN and RPN at the same time.

Because both NRPN and RPN rely on the same midi CCs for their value in the Midi standard, when the arduino midi library checks the state of its current rpn or nrpn, these checks should be checking if either has been set.

To quote Philip Rees

The fact that separate Controller pairs are designated for the NRPN number and the RPN number may suggest that a MIDI channel could have simultaneously a current NRPN and a current RPN. However, NRPNs and RPNs share a common mechanism for setting the parameter value. Therefore there is only one active parameter number per channel.

Its late and I'm not 100% sure what the best way of combining the two state variables would be (maybe 1 unsigned state variable & a boolean/constant for which type it is), but I am down to fix it myself if that seems the best way to go.

matthew-a-dunlap avatar Dec 12 '18 08:12 matthew-a-dunlap