react-fontawesome
react-fontawesome copied to clipboard
ariaLabel renders with both aria-hidden and aria-label
This would mean the aria-label would be ignored by screen readers!
If ariaLabel is passed as a property it should not add the aria-hidden="true"
I too have come across this issue I had to explicitly add aria-hidden="false" to stop this from happening.
I have just come across this issue myself and it still persists in Dec 2020 :) using
"@fortawesome/fontawesome-svg-core": "^1.2.32",
"@fortawesome/free-solid-svg-icons": "^5.15.1",
"@fortawesome/react-fontawesome": "^0.1.13",```
repro case here https://codesandbox.io/s/elated-sea-2ly3w
It seems very odd that we have to manually make sure that aria-hidden is set to false when the icons are obviously showing. @robmadole has anyone from FortAwesome looked at this since the label was added?
Bumping this because I also find it silly to manually set aria-hidden to false if an aria-label is provided.