Incompatible with sassc-rails

[adamrunner]

On a recent project I've been working on I decided to use the C implementation of SASS - as it's significantly faster. However it appeared that font awesome was explicitly requiring sass-rails which was causing asset compilation to fail when I removed sass-rails and replaced it sassc-rails.

Specifically here.

On my project I was able to remove this line and still have font-awesome function correctly, however I could see where dependencies weren't handled properly this could potentially be an issue.

If anyone has a solution to making font-awesome-sass compatible with both sass-rails and sassc-rails I'm interested!

[phiggins]

Hi @adamrunner,

I have no experience with this, just passing through and saw your issue. It looks like there's some discussion of this problem in this sassc-rails issue: https://github.com/sass/sassc-rails/issues/6

[ansonhoyt]

Another place to compare, ActiveAdmin resolved this by replacing their dependency on sass-rails with a dependency on sass. See issue https://github.com/activeadmin/activeadmin/issues/5031 and pull request https://github.com/activeadmin/activeadmin/pull/5037.

[ansonhoyt]

@supercodepoet took care of this in https://github.com/FortAwesome/font-awesome-sass/commit/02d7e2dfbf3de6228df618f166b30ae4001e5240 by removing the development dependency on sass-rails. Later in https://github.com/FortAwesome/font-awesome-sass/commit/2cfca7ba60cd7bc065bcabfdbc6c476ca1a2f9ad, he replaced runtime dependency on sass (now that ruby-sass is deprecated) with sassc.

@adamrunner, I think that thoroughly solves this issue. I'm happily dropping gem 'sass-rails', require: false from my Gemfile.

For details, see the history of font-awesome-sass.gemspec

Edit: fixed my grammar

[adamrunner]

Oh I'll have to check this out and see if it fixes the incompatibility I was having! I'll close the issue after I confirm it.