ember-fontawesome icon indicating copy to clipboard operation
ember-fontawesome copied to clipboard

`htmlSafe` From `@ember/string` Is Deprecated

Open nadnoslen opened this issue 4 years ago • 3 comments

Console deprecation warnings are now present with Ember-3.25 as htmlSafe should actually be imported via @ember/template.

Essentially replace: import { htmlSafe } from '@ember/string' with import { htmlSafe } from '@ember/template'

nadnoslen avatar Feb 11 '21 02:02 nadnoslen

import { htmlSafe } from '@ember/template'; seems to have been around since Ember 3.8. No action required in this addon's README. Thanks for maintaining!

nadnoslen avatar Feb 11 '21 02:02 nadnoslen

Looks like this will still be a problem until this is resolved? 🤷‍♂️

https://github.com/emberjs/ember.js/issues/19393

nadnoslen avatar Feb 27 '21 01:02 nadnoslen

Note from core team here: https://discuss.emberjs.com/t/fixing-htmlsafe-and-ishtmlsafe-deprecation/18639/2

Upgrading to Ember 3.25.2 should turn down that deprecation noise:

  • https://github.com/emberjs/ember.js/releases/tag/v3.25.2
  • https://github.com/emberjs/ember.js/pull/19396

nadnoslen avatar Mar 09 '21 18:03 nadnoslen