angular-fontawesome icon indicating copy to clipboard operation
angular-fontawesome copied to clipboard

Compatibility with theming in the html

Open Chudroy opened this issue 2 years ago • 1 comments

Like with Angular Material Components, the ability to use the syntax color="primary", for example. Like so:

<fa-icon [icon]="faGithub" size="2x" color="primary"></fa-icon>

for example

Chudroy avatar Aug 14 '22 16:08 Chudroy

It should be pretty easy to "theme" icons using regular CSS, either with classes or CSS variables.

https://stackblitz.com/edit/angular-ivy-ajrhxl?file=src/styles.css

It feels like unnecessary complexity to have dedicated theming API given the narrow scope of the angular-fontawesome. Is there some specific use case you have in mind which can be improved by having a dedicated theming API vs the above suggestion?

devoto13 avatar Aug 15 '22 14:08 devoto13

At this point it does not look like it is worth to introduce a dedicated theming API for the library.

devoto13 avatar Nov 11 '22 20:11 devoto13