angular-fontawesome icon indicating copy to clipboard operation
angular-fontawesome copied to clipboard

Icon size "xl" and others not included in SizeProp type

Open Dhug95 opened this issue 2 years ago • 2 comments

Describe the problem

When setting "xl" or other new sizes as "size" property of a fa-icon element, an error message appears saying that the type is not assignable because not included in SizeProp.

Screenshot 2022-03-21 at 16 49 45

Screenshot 2022-03-21 at 16 56 30

What did you expect?

"xl" size, as well as "2xs", "2xl", has been added as stated on official FontAwesome documentation

Screenshot 2022-03-21 at 16 49 25

Reproducible test case

Here a simple reproduction of the problem.

Dhug95 avatar Mar 21 '22 16:03 Dhug95

@robmadole @mlwilkerson It should probably be addresed in the @fortawesome/fontawesome-svg-core package here. What do you think?

devoto13 avatar Mar 22 '22 07:03 devoto13

@devoto13 yep, agreed. We'll get it looked at.

robmadole avatar Mar 26 '22 20:03 robmadole

Fixed in @fortawesome/[email protected].

devoto13 avatar Nov 12 '22 20:11 devoto13