whackage icon indicating copy to clipboard operation
whackage copied to clipboard

hot reloading not working

Open aubsw opened this issue 8 years ago • 4 comments

Hi, I think I'm seeing the exact same issue as #6

It seems that the whack server isn't watching my local dependancies while the server is running. I do get my updated files if I kill and restart the server. Is this expected?

Would be totally sick if I didn't have to restart the server, though even the current behavior is still a significant step up from before :)

Node: 8.4 npm: 5.5.1 rsync: 2.6.9 whackage: 1.2.0 RN: 0.49.5 Mac OS X Sierra

Thanks!

aubsw avatar Nov 07 '17 18:11 aubsw

I had the same issue @aubreywahl

The problem was the dependency in my whackage.json file had a trailing slash.
Removing that slash fixed everything

JustinKasad avatar Feb 21 '18 23:02 JustinKasad

@JustinKasad You had a trailing slash where? Not working here as well.

Node: 9.5.0
NPM: 5.6.0
whackage: 1.3.0
macOS 10.13.9
{
  "include": "/**/*.js",
  "exclude": [
    "/node_modules/*",
    ".babelrc",
    ".git"
  ],
  "dependencies": {
    "delta-client-blocks": "../client-blocks"
  }
}

wouterds avatar Mar 02 '18 15:03 wouterds

Trailing slash was a problem for me too. bash's path completion when typing whack link ../some-dir/ adds a trailing slash by default which then gets added to the whackage.json file which then breaks hot reloading. Sounds like an easy fix. Wish I had some free time right now to PR it.

treyp avatar Mar 20 '18 16:03 treyp

Actually, it is kinda working if I can make the component re-render myself, eg by switching views.

wouterds avatar Mar 20 '18 16:03 wouterds