victory
victory copied to clipboard
Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-discontinuous-scale/**/skipWeekends.js
When combine VictoryVoronoiContainer
with
scaleDiscontinuous(
d3Scale.scaleTime()
).discontinuityProvider(discontinuitySkipWeekends())
from d3fc-discontinuous-scale there would be an error: TypeError: date.getDay is not a function when hovering the Chart.
⚠️ No Changeset found
Latest commit: 28f0d88e50042008458c12545d4983e986897b32
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
victory | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 4, 2024 0:44am |
This code was cause all usages to require a Date component. Do you have some sample code/reproduction issue that we can help you find a better solution?
I see. The sample data indeed uses Date instance for the X-axis. I guess there is no choice than convert it to timestamp and implement skip weekend function myself.