victory icon indicating copy to clipboard operation
victory copied to clipboard

Toggling VictoryArea causes flikkering

Open Marvedog opened this issue 1 year ago • 3 comments

Describe the bug Toggling a VictoryArea in a VictoryStack of VictoryAreas causes flikkering.

Victory version victory-native: 36.6.7

Code Sandbox link

        <VictoryChart domain={{y: [0, 30]}}>
          <VictoryStack>
            <VictoryArea data={[4, 5, 3, 3, 5, 2, 4, 5, 3, 4, 5, 4]} />
            <VictoryArea data={[9, 6, 10, 4, 5, 3, 0, 0, 0, 3, 5, 2]} />
            <VictoryArea data={[1, 2, 1, 2, 2, 4, 0, 0, 3, 1, 1, 1]} />
          </VictoryStack>
        </VictoryChart>

To Reproduce

  1. With the repro code just remove second VictoryArea graph from the DOM
  2. Add it back to the DOM
  3. The topmost VictoryArea graph in the stack will flicker when reintroducing the second VictoryArea graph to the DOM

Expected behavior I would expect it not to flicker, which happens when doing it on web e.g., https://formidable.com/open-source/victory/docs/victory-stack#victorystack.

Screenshots untitled.webm

Desktop (please complete the following information):

  • OS: Android
  • Browser N/A
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: Pixel 2 Emulator
  • OS: Android
  • Browser N/A
  • Version 11.0 (R) - API 30

Additional context I am happy to provide more info if needed.

Marvedog avatar Sep 18 '22 20:09 Marvedog

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] avatar Feb 23 '24 21:02 github-actions[bot]

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

This is still an issue.

Marvedog avatar Feb 27 '24 12:02 Marvedog

Hi there! It looks like your issue requires a minimal reproducible example, but it is invalid or absent. Please prepare such an example and share it with us.

The best way to get attention to your issue is to provide a clean and easy way for a developer to reproduce the issue on their own machine. Please do not provide your entire project, or a project with more code than is necessary to reproduce the issue.

A side benefit of going through the process of narrowing down the minimal amount of code needed to reproduce the issue is that you may get lucky and discover that the bug is due to a mistake in your application code that you can quickly fix on your own.

Resources

Common concerns

"I didn't have time to create one"

That's understandable, it can take some time to prepare. We ask that you hold off on filing an issue until you are able to fully complete the required fields in the issue template.

"You can reproduce it by yourself by creating a project and following these steps"

This is useful knowledge, but it's still valuable to have the resulting project that is produced from running the steps, where you have verified you can reproduce the issue.

victory-ci avatar Feb 27 '24 12:02 victory-ci

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] avatar May 28 '24 00:05 github-actions[bot]

@victory-ci The provided code sample reproduce the issue. If you do not find this feedback valuable to improve your library, feel free to close this.

Marvedog avatar May 28 '24 07:05 Marvedog

Hi @Marvedog we were not able to reproduce this one, but I will bump it up our queue and have someone else attempt to reproduce it.

carbonrobot avatar Jun 03 '24 20:06 carbonrobot

Hey @Marvedog, I also tested this issue locally, but was unable to replicate. Considering this, I'll go ahead and mark this as closed for now until we get additional reports, or until someone else is able to test and reliably reproduce this issue.

masiddee avatar Jun 12 '24 20:06 masiddee