victory icon indicating copy to clipboard operation
victory copied to clipboard

VictoryLine animate prop does not accept an object

Open ljukas opened this issue 2 years ago • 0 comments

Describe the bug In the transition to typescript for VictoryLine a type override for the prop animate was made that breaks the typing. You can no longer give the animate prop an object without getting a type error. This is because it overrides the default of accepting a boolean or an object and now only accepts a boolean.

Victory version 36.5.4

Expected behavior The VictoryLine animate prop should accept an object.

Screenshots The commit that caused the issue.

See this commit, the addition at the bottom here that adds animate: boolean to the props is the culprit, it can be safely removed.

ljukas avatar Jul 12 '22 07:07 ljukas