victory
victory copied to clipboard
[victory-native] VictoryPie border width is inconsistent with Samsung Galaxy devices.
Describe the bug Samsung Galaxy border widths are barely visible relative to Google Pixel and other Android devices.
Victory version
victory-native: 36.4.1
Code Sandbox link
You will need to run this on a Google Pixel or any other Android phone vs Samsung Galaxy to tell the difference. They all look the same in the sandbox.
https://snack.expo.dev/@gsong-moves/victory-pie-looks-small-on-samsung-galaxy-devices
To Reproduce Steps to reproduce the behavior:
- Run on a Samsung Galaxy device. The border width of the ring will be barely visible, sometimes invisible depending on the device.
- Run on a non-Samsung device.
Expected behavior Samsung galaxy devices does not render the Victory Pie inner radius the same way as other Android devices.
Screenshots
Google Pixel 5
Samsung Galaxy S9-22
Extreme example (The border is so thin that no colors show up):
Desktop (please complete the following information): N/A
Smartphone (please complete the following information):
- Device: Samsung Galaxy S9 to S22
- OS: Android
- Version: 9, 10 (haven't tested other ones)
Additional context The inner radius differs even across different Samsung Galaxy devices.
We have tested on a dozen devices. Including:
![Screen Shot 2022-06-24 at 2 38 39 PM](https://user-images.githubusercontent.com/86622911/175645516-7de520ef-adf1-45c5-9b7b-772a0c0e30de.png)
I suspect this may have to do with lack of support for HiDPI on certain Android devices.
Hi everyone, we are transitioning all Native development to our new Victory Native XL library which is purpose built for supporting Native. Many of the design decisions we made in this version of Victory is not ideal for Native development.